Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TPG >5.22)!: added vpc sc dry run mode option #894

Merged

Conversation

imrannayer
Copy link
Contributor

@imrannayer imrannayer commented Mar 26, 2024

Fix #893
fix #674

@imrannayer imrannayer requested a review from a team as a code owner March 26, 2024 22:51
@imrannayer
Copy link
Contributor Author

@bharathkkb plz review

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @imrannayer

@bharathkkb
Copy link
Member

/gcbrun

@imrannayer imrannayer requested a review from bharathkkb March 27, 2024 17:21
@imrannayer
Copy link
Contributor Author

@bharathkkb can u plz run the integration test again?
Thanks

@bharathkkb
Copy link
Member

/gcbrun

@bharathkkb bharathkkb merged commit 0cade7f into terraform-google-modules:master Apr 2, 2024
4 checks passed
@imrannayer imrannayer deleted the feat/add-vpc-sc-dry-run branch April 2, 2024 14:15
@imrannayer imrannayer self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to add project in VPC SC in Dry Run Mode export bucket_name in output
2 participants